Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: delete '.test.bin' files for 'make clean' #49447

Merged
merged 1 commit into from Dec 21, 2023

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Dec 13, 2023

What problem does this PR solve?

Issue Number: ref #49070

Problem Summary:

What changed and how does it work?

After #30822, make ut will build the .test.bin files for each of the _test.go file and run them in parallel and clean .test.bin files. However, when make ut failed because of any reason, the cleanup will not happen and leave a large number of .test.bin files:

➜  tidb git:(bb7133/make_clean) ✗ find . -name '*.test.bin' -print0 | xargs -0 du -hsc
 56M	./pkg/statistics/handle/lockstats/lockstats.test.bin
136M	./pkg/statistics/handle/handletest/lockstats/lockstats.test.bin
136M	./pkg/statistics/handle/handletest/handletest.test.bin
...
136M	./pkg/session/resourcegrouptest/resourcegrouptest.test.bin
136M	./pkg/session/temporarytabletest/temporarytabletest.test.bin
 25G	total

IMO it's better to make .test.bin files cleanable by make clean and remove them from .gitignore files so that developers will be aware of them(when they're there) and the large amount of size.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • None

Documentation

  • None

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #49447 (6477fb4) into master (1cfb3b9) will increase coverage by 0.5749%.
Report is 65 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49447        +/-   ##
================================================
+ Coverage   70.9865%   71.5614%   +0.5749%     
================================================
  Files          1368       1423        +55     
  Lines        399849     428067     +28218     
================================================
+ Hits         283839     306331     +22492     
- Misses        96192     102873      +6681     
+ Partials      19818      18863       -955     
Flag Coverage Δ
integration 45.2507% <ø> (?)
unit 70.9865% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 46.5258% <ø> (-6.3591%) ⬇️

@bb7133
Copy link
Member Author

bb7133 commented Dec 13, 2023

PTAL @tiancaiamao @hawkingrei

@@ -6,7 +6,6 @@ coverage.out
*.iml
*.swp
*.log
*.test.bin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still be retained to avoid unnecessary submissions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give me some example about 'submissions'?

Copy link

ti-chi-bot bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Dec 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-14 06:51:42.924615917 +0000 UTC m=+511793.961842845: ☑️ agreed by tiancaiamao.
  • 2023-12-21 06:30:39.287879003 +0000 UTC m=+1115330.325105934: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit a022451 into pingcap:master Dec 21, 2023
18 checks passed
@bb7133 bb7133 deleted the bb7133/make_clean branch December 22, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants