Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: set OverflowAsWarning for insert statement in non-strict sql mode (#49383) #49458

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49383

What problem does this PR solve?

Issue Number: close #49369

Problem Summary:

What changed and how does it work?

Fix the compatibility issue.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

In non-strict SQL mode, treat the overflow error as warning in insert statement.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 labels Dec 14, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@859fade). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head d005596 differs from pull request most recent head ff18c5b. Consider uploading reports for the commit ff18c5b to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #49458   +/-   ##
================================================
  Coverage               ?   73.6253%           
================================================
  Files                  ?       1087           
  Lines                  ?     349487           
  Branches               ?          0           
================================================
  Hits                   ?     257311           
  Misses                 ?      75643           
  Partials               ?      16533           

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 22, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 22, 2023
Copy link

ti-chi-bot bot commented Dec 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Dec 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-22 03:15:34.889769343 +0000 UTC m=+1190025.926996270: ☑️ agreed by lcwangchao.
  • 2023-12-22 03:41:45.041385773 +0000 UTC m=+1191596.078612701: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot bot merged commit 1cc4f87 into pingcap:release-6.5 Dec 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants