Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdutil: wait after updating region label rules #49479

Merged
merged 10 commits into from Dec 21, 2023

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #49477

Problem Summary:

See #49477.

What changed and how does it work?

Sleep 10 milliseconds after posting a label rule.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    mysql> alter table t add index i(a);
    Query OK, 0 rows affected (0.73 sec)
    
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2023
Copy link

tiprow bot commented Dec 14, 2023

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

br/pkg/pdutil/pd.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #49479 (1b92b15) into master (d2f3f36) will increase coverage by 0.5389%.
Report is 8 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49479        +/-   ##
================================================
+ Coverage   70.9858%   71.5247%   +0.5389%     
================================================
  Files          1368       1424        +56     
  Lines        398550     418191     +19641     
================================================
+ Hits         282914     299110     +16196     
- Misses        95871     100207      +4336     
+ Partials      19765      18874       -891     
Flag Coverage Δ
integration 44.0948% <0.0000%> (?)
unit 70.9858% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.2795% <0.0000%> (-5.6245%) ⬇️

Copy link

ti-chi-bot bot commented Dec 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-14 13:11:17.646877069 +0000 UTC m=+534568.684103989: ☑️ agreed by lance6716.
  • 2023-12-14 13:34:42.445102541 +0000 UTC m=+535973.482329468: ☑️ agreed by YuJuncen.

Copy link
Contributor

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Defined2014
Copy link
Contributor

Do we need to link the default of patrol-region-interval?

FYI https://github.com/tikv/pd/blob/a09717bcd9da5fb0db095429a7f93c7cfa1ee660/pkg/schedule/config/config.go#L67

Do we have a easy way to get PD config in tidb side?

@HuSharp
Copy link
Contributor

HuSharp commented Dec 15, 2023

Do we need to link the default of patrol-region-interval?
FYI tikv/pd@a09717b/pkg/schedule/config/config.go#L67

Do we have a easy way to get PD config in tidb side?

for this config, can GET from HTTP interface pd/api/v1/config/schedule

I noticed there is already a func GetPDScheduleConfig in TiDB, do we need to check from it?

@tangenta
Copy link
Contributor Author

@HuSharp I think it is not necessary to explicitly depend on PD config since this is a tiny enhancement.

@tangenta
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Dec 15, 2023

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tangenta
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Dec 15, 2023

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor

/retest

Copy link

tiprow bot commented Dec 15, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor

/retest

Copy link

tiprow bot commented Dec 18, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor

/retest

Copy link

tiprow bot commented Dec 18, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2023
@tangenta tangenta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2023
@ti-chi-bot ti-chi-bot bot removed the approved label Dec 20, 2023
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2023
Copy link

ti-chi-bot bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lance6716, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 20, 2023
@Defined2014
Copy link
Contributor

Maybe could unhold this PR now? @tangenta

@tangenta
Copy link
Contributor Author

/unhold

@tangenta tangenta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 21, 2023
@ti-chi-bot ti-chi-bot bot merged commit b1e5d61 into pingcap:master Dec 21, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create index on a small table is slow
5 participants