statistics: add some key info in sync load timeout log #49630
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
size/XS
|
/cherry-pick release-6.5 |
|
@elsa0520: once the present PR merges, I will cherry-pick it on top of release-6.5 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49630 +/- ##
================================================
+ Coverage 70.9799% 71.4592% +0.4792%
================================================
Files 1368 1423 +55
Lines 398711 416468 +17757
================================================
+ Hits 283005 297605 +14600
- Misses 95935 100064 +4129
+ Partials 19771 18799 -972
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pkg/statistics/column.go
Outdated
| @@ -168,7 +168,9 @@ func (c *Column) IsInvalid( | |||
| if (!c.IsStatsInitialized() || c.IsLoadNeeded()) && stmtctx != nil { | |||
| if stmtctx.StatsLoad.Timeout > 0 { | |||
| logutil.BgLogger().Warn("Hist for column should already be loaded as sync but not found.", | |||
| zap.String(strconv.FormatInt(c.Info.ID, 10), c.Info.Name.O)) | |||
| zap.String("table_id", strconv.FormatInt(c.PhysicalID, 10)), | |||
There was a problem hiding this comment.
You can replace it with zap.Int.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
|
/ok-to-test |
|
/test all |
1 similar comment
|
/test all |
|
@elsa0520: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #49631
Problem Summary:
What changed and how does it work?
Add table id in timeout sync load log
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.