Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binding: fix linter for prealloc in the GetAllBindings #49651

Merged
merged 1 commit into from Dec 21, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Dec 21, 2023

What problem does this PR solve?

Issue Number: close None

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Merging #49651 (f6ff1f4) into master (11aefee) will increase coverage by 0.4438%.
Report is 3 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49651        +/-   ##
================================================
+ Coverage   70.9842%   71.4280%   +0.4438%     
================================================
  Files          1368       1423        +55     
  Lines        398566     415891     +17325     
================================================
+ Hits         282919     297063     +14144     
- Misses        95882     100034      +4152     
+ Partials      19765      18794       -971     
Flag Coverage Δ
integration 43.8442% <100.0000%> (?)
unit 70.9840% <ø> (-0.0002%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.3165% <ø> (-5.5807%) ⬇️

@hawkingrei
Copy link
Member Author

/retest

Copy link
Member

@hi-rustin hi-rustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! 👍

Copy link

ti-chi-bot bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Dec 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-21 05:54:30.52362572 +0000 UTC m=+1113161.560852647: ☑️ agreed by qw4990.
  • 2023-12-21 06:40:57.748985814 +0000 UTC m=+1115948.786212746: ☑️ agreed by hi-rustin.

@ti-chi-bot ti-chi-bot bot merged commit 5c279d8 into pingcap:master Dec 21, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants