Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: refactor like and ilike cache logic #49676

Merged
merged 1 commit into from
Dec 25, 2023
Merged

expression: refactor like and ilike cache logic #49676

merged 1 commit into from
Dec 25, 2023

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Dec 21, 2023 •
edited

What problem does this PR solve?

Issue Number: close #49674

What changed and how does it work?

Same as #49584 . In this PR we refactor some cache logic for like and ilike function

relies on #49678, we should fix datarace first

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 21, 2023
@lcwangchao
Copy link
Collaborator Author

/retest

@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited

Codecov Report

Merging #49676 (8a0cb48) into master (ebd259c) will increase coverage by 0.4252%.
Report is 19 commits behind head on master.
The diff coverage is 69.3877%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #49676        +/-   ##
================================================
+ Coverage   70.9587%   71.3839%   +0.4252%     
================================================
  Files          1368       1428        +60     
  Lines        397193     416486     +19293     
================================================
+ Hits         281843     297304     +15461     
- Misses        95651     100375      +4724     
+ Partials      19699      18807       -892
Flag Coverage Δ
integration 43.9244% <69.3877%> (?)
unit 70.9581% <ø> (-0.0006%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.1991% <ø> (-5.7050%) ⬇️

@lcwangchao
Copy link
Collaborator Author

lcwangchao commented Dec 21, 2023 •
edited

/hold

We should merge #49678 first

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2023
@lcwangchao
Copy link
Collaborator Author

/retest

YangKeao
YangKeao approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcwangchao
Copy link
Collaborator Author

/test tiprow_fast_test

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 21, 2023

@lcwangchao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pull-integration-ddl-test
  • /test pull-mysql-client-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test canary-notify-when-compatibility-sections-changed
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-br-integration-test
  • /test pull-common-test
  • /test pull-e2e-test
  • /test pull-integration-common-test
  • /test pull-integration-copr-test
  • /test pull-integration-jdbc-test
  • /test pull-integration-mysql-test
  • /test pull-integration-nodejs-test
  • /test pull-lightning-integration-test
  • /test pull-sqllogic-test
  • /test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test
  • pingcap/tidb/pull_integration_ddl_test
  • pingcap/tidb/pull_mysql_client_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lcwangchao lcwangchao force-pushed the like_ilike_cache branch 3 times, most recently from e6ac5b6 to e4d8fb7 Compare December 22, 2023 04:42
@lcwangchao
Copy link
Collaborator Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2023
@lcwangchao
Copy link
Collaborator Author

/retest

xzhangxian1008
xzhangxian1008 approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 22, 2023

@xzhangxian1008: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lcwangchao
Copy link
Collaborator Author

/test tiprow_fast_test

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 22, 2023

@lcwangchao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pull-integration-ddl-test
  • /test pull-mysql-client-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test canary-notify-when-compatibility-sections-changed
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-br-integration-test
  • /test pull-common-test
  • /test pull-e2e-test
  • /test pull-integration-common-test
  • /test pull-integration-copr-test
  • /test pull-integration-jdbc-test
  • /test pull-integration-mysql-test
  • /test pull-integration-nodejs-test
  • /test pull-lightning-integration-test
  • /test pull-sqllogic-test
  • /test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test
  • pingcap/tidb/pull_integration_ddl_test
  • pingcap/tidb/pull_mysql_client_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

windtalker
windtalker approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, xzhangxian1008, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-21 09:48:22.724181868 +0000 UTC m=+1127193.761408795: ☑️ agreed by YangKeao.
  • 2023-12-25 02:09:56.163817756 +0000 UTC m=+1445287.201044683: ☑️ agreed by windtalker.

@lcwangchao
Copy link
Collaborator Author

/retest

3 similar comments
@lcwangchao
Copy link
Collaborator Author

/retest

@lcwangchao
Copy link
Collaborator Author

/retest

@lcwangchao
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 4e9f006 into pingcap:master Dec 25, 2023
18 checks passed
@lcwangchao lcwangchao deleted the like_ilike_cache branch December 25, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@YangKeao YangKeao YangKeao approved these changes

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor cache logic for like and ilike
4 participants
@lcwangchao @windtalker @YangKeao @xzhangxian1008