ddl: forbid create Generated column with Grouping function
#49930
Conversation
ti-chi-bot
bot
added
release-note-none
needs-cherry-pick-release-5.4
|
Hi @jiyfhust. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
ti-chi-bot
bot
added
ok-to-test
do-not-merge/needs-tests-checked
and removed
do-not-merge/needs-tests-checked
labels
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49930 +/- ##
=================================================
+ Coverage 70.9365% 81.7135% +10.7770%
=================================================
Files 1368 2502 +1134
Lines 396016 725055 +329039
=================================================
+ Hits 280920 592468 +311548
- Misses 95433 111511 +16078
- Partials 19663 21076 +1413
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/auto-cc |
| @@ -289,6 +289,11 @@ type illegalFunctionChecker struct { | |||
| func (c *illegalFunctionChecker) Enter(inNode ast.Node) (outNode ast.Node, skipChildren bool) { | |||
| switch node := inNode.(type) { | |||
| case *ast.FuncCallExpr: | |||
| // Grouping function is not allowed, issue #49909. | |||
| if node.FnName.L == ast.Grouping { | |||
There was a problem hiding this comment.
I think it's better to add it to IllegalFunctions4GeneratedColumns ?
There was a problem hiding this comment.
I think it's better to add it to
IllegalFunctions4GeneratedColumns?
illegalFunctionChecker is for that. It parse the expr and set flag, then IllegalFunctions4GeneratedColumns judge it.
|
/test pull-integration-ddl-test |
|
@jiyfhust: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc Benjamin2037 tangenta wjhuang2016 ywqzzy zimulala |
ti-chi-bot
bot
requested review from
Benjamin2037,
wjhuang2016,
ywqzzy and
zimulala
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, mjonss, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test mysql-test |
|
@jiyfhust: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #49909
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.