New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: let select push across project #5016

Merged
merged 7 commits into from Nov 7, 2017

Conversation

Projects
None yet
4 participants
@hanfei1991
Member

hanfei1991 commented Nov 6, 2017

To support generated column index.

hanfei1991 and others added some commits Nov 6, 2017

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Nov 6, 2017

Member

/run-all-test

Member

hanfei1991 commented Nov 6, 2017

/run-all-test

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Nov 6, 2017

Member

/run-all-tests

Member

hanfei1991 commented Nov 6, 2017

/run-all-tests

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Nov 7, 2017

Member

/run-all-tests

Member

shenli commented Nov 7, 2017

/run-all-tests

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Nov 7, 2017

Member

LGTM

Member

shenli commented Nov 7, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli
Member

shenli commented Nov 7, 2017

@winoros PTAL

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 7, 2017

Member

LGTM

Member

coocood commented Nov 7, 2017

LGTM

@winoros

winoros approved these changes Nov 7, 2017

LGTM

@winoros winoros added status/LGT2 and removed status/LGT1 labels Nov 7, 2017

@hanfei1991 hanfei1991 merged commit 5a55d8b into pingcap:master Nov 7, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 73.667%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the hanfei1991:ppd branch Nov 7, 2017

spongedu added a commit to spongedu/tidb that referenced this pull request Nov 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment