Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan: let select push across project #5016

Merged
merged 7 commits into from Nov 7, 2017
Merged

plan: let select push across project #5016

merged 7 commits into from Nov 7, 2017

Conversation

hanfei1991
Copy link
Member

To support generated column index.

@hanfei1991
Copy link
Member Author

/run-all-test

@hanfei1991
Copy link
Member Author

/run-all-tests

@shenli
Copy link
Member

shenli commented Nov 7, 2017

/run-all-tests

@shenli
Copy link
Member

shenli commented Nov 7, 2017

LGTM

@shenli
Copy link
Member

shenli commented Nov 7, 2017

@winoros PTAL

@hanfei1991 hanfei1991 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 7, 2017
@coocood
Copy link
Member

coocood commented Nov 7, 2017

LGTM

winoros
winoros approved these changes Nov 7, 2017
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winoros winoros added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 7, 2017
@hanfei1991 hanfei1991 merged commit 5a55d8b into pingcap:master Nov 7, 2017
@hanfei1991 hanfei1991 deleted the ppd branch November 7, 2017 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hanfei1991 @shenli @coocood @winoros