Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: use another way to get index uniqueness during task exec init #50378

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jan 12, 2024

What problem does this PR solve?

Issue Number: ref #50307, close #50435

What changed and how does it work?

This PR fixes the stuck issue cause by indexInfo not found when cancelling the task.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 12, 2024
Copy link

tiprow bot commented Jan 12, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Merging #50378 (8038968) into master (ad1592c) will decrease coverage by 14.4333%.
Report is 23 commits behind head on master.
The diff coverage is 80.7692%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50378         +/-   ##
=================================================
- Coverage   70.0238%   55.5905%   -14.4333%     
=================================================
  Files          1444       1556        +112     
  Lines        419997     587796     +167799     
=================================================
+ Hits         294098     326759      +32661     
- Misses       105570     238319     +132749     
- Partials      20329      22718       +2389     
Flag Coverage Δ
integration 36.8041% <78.8461%> (?)
unit 70.1514% <17.3076%> (+0.1275%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 55.7861% <ø> (+6.1283%) ⬆️

Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if existing integration test can cover this

@tangenta tangenta changed the title ddl: remove unnecessary code from dist task ddl: use another way to get index uniqueness during task exec init Jan 12, 2024
go.mod Outdated
@@ -69,7 +69,7 @@ require (
github.com/joho/sqltocsv v0.0.0-20210428211105-a6d6801d59df
github.com/kisielk/errcheck v1.6.3
github.com/klauspost/compress v1.17.1
github.com/ks3sdklib/aws-sdk-go v1.2.9
github.com/ks3sdklib/aws-sdk-go v1.2.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? we just upgrade it. #50179

Copy link
Contributor Author

@tangenta tangenta Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a network problem with ks3 Read(). I want to make a quick test by downgrading it.

@tangenta tangenta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2024
@tangenta tangenta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jan 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-12 10:18:40.283605693 +0000 UTC m=+611309.867859379: ☑️ agreed by D3Hunter.
  • 2024-01-16 03:21:24.944862989 +0000 UTC m=+239726.509160694: ☑️ agreed by Benjamin2037.

Copy link

ti-chi-bot bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit a257521 into pingcap:master Jan 16, 2024
30 of 34 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #50452.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 16, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #50497.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 17, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add index status is always running after inject pd leader io delay 500ms lasts for 2mins
5 participants