New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: use types.Row to write result set. #5056
Conversation
Prepare to use Chunk
@zz-jason @tiancaiamao PTAL |
/run-all-tests |
/run-all-tests |
/run-common-test tidb-test=pr/401 |
/run-common-test tidb-test=pr/401 |
/run-common-test tidb-test=pr/401 |
/run-common-test tidb-test=pr/401 |
/run-all-test tidb-test=pr/401 |
expression/aggregation/avg.go
Outdated
d.SetValue(t) | ||
x = new(types.MyDecimal) | ||
err := x.FromFloat64(ctx.Value.GetFloat64()) | ||
terror.Log(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
errors.Trace(err)
expression/aggregation/sum.go
Outdated
if ctx.Value.Kind() == types.KindFloat64 { | ||
dec := new(types.MyDecimal) | ||
err := dec.FromFloat64(ctx.Value.GetFloat64()) | ||
terror.Log(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Prepare to use Chunk