Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: generate no stack warning for ErrWarnOptimizerHintUnsupportedHint #50655

Merged

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 23, 2024

…Hint

What problem does this PR solve?

Issue Number: close #49291

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…Hint

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link

ti-chi-bot bot commented Jan 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-23 08:06:56.077755065 +0000 UTC m=+861657.642052769: ☑️ agreed by qw4990.
  • 2024-01-23 08:08:25.670436611 +0000 UTC m=+861747.234734316: ☑️ agreed by AilinKid.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Merging #50655 (7a9502c) into master (8e1f5e4) will decrease coverage by 14.5725%.
Report is 7 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50655         +/-   ##
=================================================
- Coverage   70.3871%   55.8147%   -14.5725%     
=================================================
  Files          1456       1567        +111     
  Lines        420541     590217     +169676     
=================================================
+ Hits         296007     329428      +33421     
- Misses       104273     238044     +133771     
- Partials      20261      22745       +2484     
Flag Coverage Δ
integration 36.9807% <0.0000%> (?)
unit 70.4307% <100.0000%> (+0.0488%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 56.8829% <ø> (+6.3172%) ⬆️

Copy link

ti-chi-bot bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 23, 2024
@ti-chi-bot ti-chi-bot bot merged commit bf44d24 into pingcap:master Jan 23, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planner: care to use errors.new and errors.errorf as your warnings and notes
4 participants