Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix go-resty/resty/v2 HTTP request body disclosure #50777

Merged
merged 1 commit into from Jan 29, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 29, 2024

What problem does this PR solve?

Issue Number: close #50775

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added release-note-none do-not-merge/needs-tests-checked size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jan 29, 2024
Copy link

ti-chi-bot bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jan 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-29 05:41:35.556550308 +0000 UTC m=+1371337.120848002: ☑️ agreed by Defined2014.
  • 2024-01-29 05:41:47.005719642 +0000 UTC m=+1371348.570017332: ☑️ agreed by lance6716.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Merging #50777 (9537bf3) into master (1760a26) will increase coverage by 1.5442%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50777        +/-   ##
================================================
+ Coverage   70.4861%   72.0304%   +1.5442%     
================================================
  Files          1463       1463                
  Lines        433217     433217                
================================================
+ Hits         305358     312048      +6690     
+ Misses       108613     101288      -7325     
- Partials      19246      19881       +635     
Flag Coverage Δ
integration 25.4449% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.2940% <ø> (ø)
parser ∅ <ø> (∅)
br 51.1822% <ø> (+5.4537%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 62d3908 into pingcap:master Jan 29, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github.com/go-resty/resty/v2 HTTP request body disclosure
3 participants