Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: avoid thundering herd problem when timeout the stats sync load (#50956) #51066

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50956

What problem does this PR solve?

Issue Number: close #50957

Problem Summary:

What changed and how does it work?

we need to load the stats cache in the background. but if we meet the timeout, we must wait constantly to retry. it will happen thundering herd. so we need to add the rand sleep to prevent it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.1 labels Feb 8, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 8, 2024
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 13, 2024
Copy link

ti-chi-bot bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Feb 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-09 02:54:39.377525593 +0000 UTC m=+498204.944295475: ☑️ agreed by AilinKid.
  • 2024-02-13 03:57:02.86371431 +0000 UTC m=+847548.430484201: ☑️ agreed by hawkingrei.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@8f2144a). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #51066   +/-   ##
================================================
  Coverage               ?   73.4093%           
================================================
  Files                  ?       1208           
  Lines                  ?     378735           
  Branches               ?          0           
================================================
  Hits                   ?     278027           
  Misses                 ?      82943           
  Partials               ?      17765           

@ti-chi-bot ti-chi-bot bot merged commit c9644ce into pingcap:release-7.1 Feb 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants