-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/autoid_service: add lock to make API thread-safe (#50820) #51322
pkg/autoid_service: add lock to make API thread-safe (#50820) #51322
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #51322 +/- ##
================================================
Coverage ? 73.4014%
================================================
Files ? 1210
Lines ? 378987
Branches ? 0
================================================
Hits ? 278182
Misses ? 83031
Partials ? 17774 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #50820
What problem does this PR solve?
Issue Number: close #50819
Problem Summary:
What changed and how does it work?
The exposed API should be thread-safe, and
forceRebase
allocAutoID
alloc4Unsigned
alloc4Signed
... all those internal functions should be called under lock.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.