Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/autoid_service: add lock to make API thread-safe (#50820) #51322

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50820

What problem does this PR solve?

Issue Number: close #50819

Problem Summary:

What changed and how does it work?

The exposed API should be thread-safe, and forceRebase allocAutoID alloc4Unsigned alloc4Signed ... all those internal functions should be called under lock.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@2a0d877). Click here to learn what that means.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #51322   +/-   ##
================================================
  Coverage               ?   73.4014%           
================================================
  Files                  ?       1210           
  Lines                  ?     378987           
  Branches               ?          0           
================================================
  Hits                   ?     278182           
  Misses                 ?      83031           
  Partials               ?      17774           

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Feb 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-27 10:08:13.725753783 +0000 UTC m=+956582.473376888: ☑️ agreed by hawkingrei.
  • 2024-02-27 10:14:34.511351961 +0000 UTC m=+956963.258975097: ☑️ agreed by bb7133.

@ti-chi-bot ti-chi-bot bot merged commit a3de4a8 into pingcap:release-7.1 Feb 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants