Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ignore some routines from grpc that's not waited on close #51496

Merged
merged 1 commit into from Mar 5, 2024

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Mar 5, 2024

What problem does this PR solve?

Issue Number: close #51212

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2024
Copy link

tiprow bot commented Mar 5, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #51496 (b845ea3) into master (28d211b) will increase coverage by 1.5173%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51496        +/-   ##
================================================
+ Coverage   70.7151%   72.2325%   +1.5173%     
================================================
  Files          1462       1462                
  Lines        435369     435369                
================================================
+ Hits         307872     314478      +6606     
+ Misses       108184     100938      -7246     
- Partials      19313      19953       +640     
Flag Coverage Δ
integration 27.0630% <ø> (?)
unit 70.4659% <ø> (-0.0482%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.2383% <ø> (+5.4146%) ⬆️

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Mar 5, 2024

/retest

Copy link

tiprow bot commented Mar 5, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Mar 5, 2024

cc @lance6716

Copy link

ti-chi-bot bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Mar 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-05 06:55:58.60441685 +0000 UTC m=+150185.626663233: ☑️ agreed by hawkingrei.
  • 2024-03-05 07:05:41.683638955 +0000 UTC m=+150768.705885343: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 703bee5 into pingcap:master Mar 5, 2024
21 of 23 checks passed
@D3Hunter D3Hunter deleted the fix-leak branch March 5, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

routine leak in import into real tikv test
3 participants