New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix InContainer check for cgroup v2 #51669
Conversation
Skipping CI for Draft Pull Request. |
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test mysql-test |
@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51669 +/- ##
================================================
+ Coverage 70.7224% 72.7454% +2.0229%
================================================
Files 1473 1473
Lines 437089 437816 +727
================================================
+ Hits 309120 318491 +9371
+ Misses 108602 99270 -9332
- Partials 19367 20055 +688
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pkg/util/cgroup/cgroup_cpu_linux.go
Outdated
// see details from https://man7.org/linux/man-pages/man5/proc.5.html | ||
if len(v) >= 8 && v[4] == "\\" && v[8] == "overlay" { | ||
// TODO: enhance this check, as overlay is not the only storage driver for container. | ||
if len(v) > 8 && v[8] == "overlay" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add tests for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manually testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in pr desc
/ok-to-test |
/retest |
/hold i will test it again manually, as the logic changed |
test again
|
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #51668
Problem Summary:
What changed and how does it work?
Check List
Tests
before
after
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.