-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema_v2: support bundles for apply diff #51715
Conversation
Hi @GMHDBJD. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This reverts commit 89233ee.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51715 +/- ##
================================================
+ Coverage 70.7154% 72.8197% +2.1042%
================================================
Files 1474 1474
Lines 437115 437182 +67
================================================
+ Hits 309108 318355 +9247
+ Misses 108636 98834 -9802
- Partials 19371 19993 +622
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pkg/infoschema/bundle_builder.go
Outdated
func (b *bundleInfoBuilder) updateTableBundles(is *infoSchema, tableID int64) { | ||
tbl, ok := is.TableByID(tableID) | ||
func (b *bundleInfoBuilder) updateTableBundles(infoSchemaInterface InfoSchema, tableID int64) { | ||
// TODO: refactor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can implement this method
func (is *infoschema) base() *infoschema {
return is
}
Then both infoschema and infoschemav2 get it:
is := infoschemaInterface.base()
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiancaiamao, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #51680
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.