Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema_v2: support bundles for apply diff #51715

Merged
merged 8 commits into from
Mar 13, 2024

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Mar 12, 2024

What problem does this PR solve?

Issue Number: ref #51680

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2024
Copy link

tiprow bot commented Mar 12, 2024

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Merging #51715 (b75aa11) into master (6bc6b91) will increase coverage by 2.1043%.
Report is 1 commits behind head on master.
The diff coverage is 93.2203%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51715        +/-   ##
================================================
+ Coverage   70.7154%   72.8197%   +2.1042%     
================================================
  Files          1474       1474                
  Lines        437115     437182        +67     
================================================
+ Hits         309108     318355      +9247     
+ Misses       108636      98834      -9802     
- Partials      19371      19993       +622     
Flag Coverage Δ
integration 48.8277% <25.0000%> (?)
unit 70.5102% <93.2203%> (-0.0110%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4256% <ø> (+5.5599%) ⬆️

@ywqzzy ywqzzy self-requested a review March 13, 2024 01:58
func (b *bundleInfoBuilder) updateTableBundles(is *infoSchema, tableID int64) {
tbl, ok := is.TableByID(tableID)
func (b *bundleInfoBuilder) updateTableBundles(infoSchemaInterface InfoSchema, tableID int64) {
// TODO: refactor
Copy link
Contributor

@tiancaiamao tiancaiamao Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can implement this method

func (is *infoschema) base() *infoschema {
    return is
}

Then both infoschema and infoschemav2 get it:

is := infoschemaInterface.base()

Copy link

ti-chi-bot bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiancaiamao, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Mar 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-13 03:45:52.024996682 +0000 UTC m=+829979.047243071: ☑️ agreed by ywqzzy.
  • 2024-03-13 03:50:03.533815891 +0000 UTC m=+830230.556062279: ☑️ agreed by tiancaiamao.

@ti-chi-bot ti-chi-bot bot merged commit 0d742d3 into pingcap:master Mar 13, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants