Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix data race in the TestProxyProtocolWithIpNoFallbackable #51791

Merged
merged 1 commit into from Mar 15, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 14, 2024

What problem does this PR solve?

Issue Number: close #51790

Problem Summary:

What changed and how does it work?

We should wait to complete the server init and start to get connection info.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Merging #51791 (f8dec0e) into master (6306512) will increase coverage by 2.0575%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51791        +/-   ##
================================================
+ Coverage   70.7550%   72.8125%   +2.0575%     
================================================
  Files          1476       1476                
  Lines        437535     437573        +38     
================================================
+ Hits         309578     318608      +9030     
+ Misses       108583      98941      -9642     
- Partials      19374      20024       +650     
Flag Coverage Δ
integration 48.7775% <ø> (?)
unit 70.5164% <ø> (-0.0562%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4406% <ø> (+5.5044%) ⬆️

Copy link

ti-chi-bot bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Mar 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-15 03:51:18.31818926 +0000 UTC m=+1003105.340435648: ☑️ agreed by Defined2014.
  • 2024-03-15 04:10:38.096238102 +0000 UTC m=+1004265.118484490: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 7ebaaa1 into pingcap:master Mar 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DATA RACE in the TestProxyProtocolWithIpNoFallbackable
3 participants