ddl: fix the wrong logic to assert whether table has foreign key (#51808) #51831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
13 tasks
ti-chi-bot
added
release-note-none
size/S
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
size/XXL
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
ti-chi-bot
bot
added
size/L
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YangKeao, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #51831 +/- ##
================================================
Coverage ? 73.9125%
================================================
Files ? 1095
Lines ? 353016
Branches ? 0
================================================
Hits ? 260923
Misses ? 75549
Partials ? 16544 |
ti-chi-bot
added
the
cherry-pick-approved
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #51808
What problem does this PR solve?
Issue Number: close #51807, close #51762
Problem Summary:
If the foreign key is an empty slice, the condition
nt.ForeignKeys != nilwill meet. It would be better to assert it withlen(nt.ForeignKeys) > 0What changed and how does it work?
Change
nt.ForeignKeys != niltolen(nt.ForeignKeys) > 0.Actually, I wonder whether there are other similar issues in TiDB. It's very likely to have bugs in similar pattern 🤔 .
Check List
Tests
Side effects
Documentation
Release note