New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema: fix regression on select table_rows from information_schema.tables for partition table #51980
Conversation
Hi @ywqzzy. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51980 +/- ##
=================================================
- Coverage 72.4625% 54.9931% -17.4694%
=================================================
Files 1478 1592 +114
Lines 365027 612905 +247878
=================================================
+ Hits 264508 337056 +72548
- Misses 81022 252569 +171547
- Partials 19497 23280 +3783
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[LGTM Timeline notifier]Timeline:
|
/hold new comments arrived |
Co-authored-by: tangenta <tangenta@126.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, lance6716, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
1 similar comment
/unhold |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #51942
Problem Summary:
In #50874 we update the updating logic of stat cache.
We only update stat cache in 2 scenes:
But the updating logic 2 didn't table partitions for partition table into consideration.
We should update each partitions when getting the table_rows for partition table.
What changed and how does it work?
Update stat cache for all partitions of partition table
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.