-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: allow parallel import with conflict detection (#52002) #52037
lightning: allow parallel import with conflict detection (#52002) #52037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
/cc @BornChanger |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-8.0 #52037 +/- ##
================================================
Coverage ? 70.6654%
================================================
Files ? 1477
Lines ? 438329
Branches ? 0
================================================
Hits ? 309747
Misses ? 109134
Partials ? 19448
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, BornChanger, lyzx2001 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #52002
What problem does this PR solve?
Issue Number: close #52001
Problem Summary:
conflict.strategy cannot be used with tikv-importer.parallel-import and tikv-importer.backend = "local" and conflict.precheck-conflict-before-import = true
What changed and how does it work?
allow parallel import with conflict detection
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.