expression: set a collation according to the arguments for ifnull in constant folding (#52119)
#52124
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
release-note
size/M
ti-chi-bot
added
the
cherry-pick-approved
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
ti-chi-bot
bot
added
size/L
|
/retest |
| tk.MustExec("insert into t values ()") | ||
| tk.MustExec(`insert into t1 values ("Hello World")`) | ||
|
|
||
| tk.MustQuery("select collation(ifnull(concat(NULL), '~'))").Check(testkit.Rows("utf8mb4_bin")) |
There was a problem hiding this comment.
The result is different from the original PR in integration test, because the connection collation of Go MySQL driver is utf8mb4_general_ci, but here it's the default value utf8mb4_bin. (For mysql cli client, it's utf8mb4_0900_ai_ci).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YangKeao, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #52124 +/- ##
================================================
Coverage ? 73.6379%
================================================
Files ? 1095
Lines ? 350925
Branches ? 0
================================================
Hits ? 258414
Misses ? 75897
Partials ? 16614 |
This is an automated cherry-pick of #52119
What problem does this PR solve?
Issue Number: close #51765
Problem Summary:
The
ifnullhas different behavior in inferring collation for constant folding and normal execution path.What changed and how does it work?
Set the collation according to the first argument in the path of constant folding.
Check List
Tests
Release note