test: add unit test for estimateTableRowSize #52144
Conversation
ti-chi-bot
bot
added
release-note-none
size/M
|
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52144 +/- ##
=================================================
- Coverage 72.4092% 53.9999% -18.4094%
=================================================
Files 1487 1679 +192
Lines 365652 638345 +272693
=================================================
+ Hits 264766 344706 +79940
- Misses 81332 269812 +188480
- Partials 19554 23827 +4273
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -2217,6 +2217,9 @@ func (w *worker) executeDistTask(t table.Table, reorgInfo *reorgInfo) error { | |||
| return err | |||
| } | |||
|
|
|||
| // EstimateTableRowSizeForTest is used for test. | |||
| var EstimateTableRowSizeForTest = estimateTableRowSize | |||
There was a problem hiding this comment.
Could we put it to pkg/ddl/ddl_test.go?
There was a problem hiding this comment.
No, we need to access it in realtikvtest package.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ywqzzy, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #52085
Problem Summary:
Add unit test for estimateTableRowSize.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.