Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema_v2: fix rename table #52151

Merged
merged 1 commit into from Mar 28, 2024
Merged

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Mar 27, 2024

What problem does this PR solve?

Issue Number: ref #50959

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
diff --git a/pkg/sessionctx/variable/tidb_vars.go b/pkg/sessionctx/variable/tidb_vars.go
index d5e9b34324..73e6f48387 100644
--- a/pkg/sessionctx/variable/tidb_vars.go
+++ b/pkg/sessionctx/variable/tidb_vars.go
@@ -1483,7 +1483,7 @@ const (
        DefTiDBSchemaVersionCacheLimit                    = 16
        DefTiDBIdleTransactionTimeout                     = 0
        DefTiDBTxnEntrySizeLimit                          = 0
-       DefTiDBSchemaCacheSize                            = 0
+       DefTiDBSchemaCacheSize                            = 1024
        DefTiDBLowResolutionTSOUpdateInterval             = 2000
make ut X='run pkg/executor/test/ddl TestRenameTable'
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 27, 2024
Copy link

tiprow bot commented Mar 27, 2024

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Merging #52151 (12cf7b3) into master (e925628) will decrease coverage by 16.0212%.
Report is 6 commits behind head on master.
The diff coverage is 86.9565%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52151         +/-   ##
=================================================
- Coverage   70.7031%   54.6820%   -16.0212%     
=================================================
  Files          1487       1600        +113     
  Lines        439607     610025     +170418     
=================================================
+ Hits         310816     333574      +22758     
- Misses       109317     253225     +143908     
- Partials      19474      23226       +3752     
Flag Coverage Δ
integration 36.6174% <73.9130%> (?)
unit 70.4456% <86.9565%> (-0.0754%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.5679% <ø> (+5.7499%) ⬆️

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 27, 2024

/retest

Copy link

tiprow bot commented Mar 27, 2024

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiancaiamao, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Mar 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-27 10:41:42.63605 +0000 UTC m=+2064529.658296387: ☑️ agreed by tiancaiamao.
  • 2024-03-28 02:29:25.112053484 +0000 UTC m=+2121392.134299872: ☑️ agreed by ywqzzy.

@tiancaiamao tiancaiamao merged commit 8bca3dd into pingcap:master Mar 28, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants