*: let our unit test cover the infoschema v2 code #52156

tiancaiamao · 2024-03-27T09:49:47Z

What problem does this PR solve?

Issue Number: ref #50959

Problem Summary:

What changed and how does it work?

Most the code can pass under infoschema v2 now.
We need a way to run the new code in our CI to prevent regression.

I change the testkit initialize code to make it:

	if intest.InTest {
		if rand.Intn(10) > 3 { // 70% chance to run infoschema v2
			tk.MustExec("set @@global.tidb_schema_cache_size = 1024")
		}
	}

Fix cases:

[FAIL]  pkg/ddl/tests/fail TestPartitionAddIndexGC
[FAIL]  pkg/infoschema/test/infoschemav2test TestSpecialSchemas
[FAIL]  pkg/disttask/framework/integrationtests TestRoleBasic
[FAIL]  pkg/executor TestTikvRegionStatus
[FAIL]  pkg/infoschema TestBuildBundle

Some of those cases success to run if we set DefTiDBSchemaCacheSize, but fail if we set the @@global.tidb_schema_cache_size variable.

Check List

Tests

Unit test

Now the CI should cover the new code.

Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2024-03-27T09:50:03Z

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2024-03-27T10:11:36Z

Codecov Report

Merging #52156 (7f664b5) into master (510f44f) will increase coverage by 1.0627%.
Report is 30 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #52156        +/-   ##
================================================
+ Coverage   74.1313%   75.1940%   +1.0627%     
================================================
  Files          1467       1489        +22     
  Lines        354270     435036     +80766     
================================================
+ Hits         262625     327121     +64496     
- Misses        72418      87021     +14603     
- Partials      19227      20894      +1667

Flag	Coverage Δ
integration	`51.7922% <33.3333%> (?)`
unit	`71.0182% <100.0000%> (-1.8612%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9957% <ø> (-2.3014%)`	⬇️
parser	`∅ <ø> (∅)`
br	`61.5604% <ø> (+18.8960%)`	⬆️

tiancaiamao · 2024-03-27T12:54:07Z

/run-unit-test

tiancaiamao · 2024-03-27T12:55:17Z

/test unit-test

tiprow · 2024-03-27T12:55:38Z

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiancaiamao · 2024-03-27T14:52:44Z

/test check-dev2

ti-chi-bot · 2024-03-27T14:52:47Z

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test unit-test

The following commands are available to trigger optional jobs:

/test canary-notify-when-compatibility-sections-changed
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-sqllogic-test
/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_mysql_client_test

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2024-03-27T14:53:06Z

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiancaiamao · 2024-03-28T02:20:53Z

/test check-dev2

tiprow · 2024-03-28T02:21:13Z

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2024-04-08T12:58:48Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

GMHDBJD

LGTM

ti-chi-bot · 2024-04-11T11:29:10Z

[LGTM Timeline notifier]

Timeline:

2024-04-09 07:04:39.724965691 +0000 UTC m=+945941.252506236: ☑️ agreed by ywqzzy.
2024-04-11 11:29:09.627636692 +0000 UTC m=+1134611.155177238: ☑️ agreed by GMHDBJD.

tiancaiamao · 2024-04-12T01:53:23Z

pkg/planner/core/binary_plan_test.go

@@ -124,6 +124,10 @@ func TestTooLongBinaryPlan(t *testing.T) {
 	require.NoError(t, logutil.InitLogger(newCfg.Log.ToLogConfig()))
 	store := testkit.CreateMockStore(t)
 	tk := testkit.NewTestKit(t, store)
+	if tk.MustQuery("select @@tidb_schema_cache_size > 0").Equal(testkit.Rows("1")) {
+		t.Skip("TODO: the performance is poor for this test under infoschema v2")


#52479 optimize the performance here, after that we do not need to skip.

easonn7 · 2024-04-12T03:01:56Z

/approve

ti-chi-bot · 2024-04-12T03:02:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, GMHDBJD, time-and-fate, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [GMHDBJD,time-and-fate,ywqzzy]
~~pkg/ddl/OWNERS~~ [ywqzzy]
~~pkg/disttask/OWNERS~~ [GMHDBJD,ywqzzy]
~~pkg/infoschema/OWNERS~~ [GMHDBJD,ywqzzy]
~~pkg/planner/OWNERS~~ [time-and-fate]
~~pkg/sessionctx/variable/OWNERS~~ [easonn7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tiancaiamao · 2024-04-12T05:17:44Z

/test pull-br-integration-test

tiprow · 2024-04-12T05:18:06Z

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ref pingcap#50959

tiancaiamao added 2 commits March 27, 2024 17:39

*: let our unit test cover the infoschema v2 code

47338b4

clean up

e78cc68

ti-chi-bot bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 27, 2024

fix build

e951afc

tiancaiamao added 2 commits March 27, 2024 19:02

Merge branch 'master' into v2-ci

5a2fb14

skip failed cases

fe46b15

ywqzzy self-requested a review March 28, 2024 02:42

tiancaiamao added 2 commits March 28, 2024 11:19

Merge branch 'master' into v2-ci

b57f63c

do not skip some cases

3a2ca11

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2024

tiancaiamao added 2 commits March 28, 2024 17:28

fix CI

bc677a3

make some test case stable

9c610e4

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2024

tiancaiamao added 3 commits March 28, 2024 21:19

fix

70cc5c6

try to make test case more stable

5d5dd46

only enable infoschema v2 in ci for unit test

de93c05

tiancaiamao requested a review from GMHDBJD March 29, 2024 06:14

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2024

ywqzzy approved these changes Apr 9, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm label Apr 9, 2024

Merge branch 'master' into v2-ci

7f664b5

ti-chi-bot bot added sig/planner SIG: Planner and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 9, 2024

GMHDBJD approved these changes Apr 11, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm labels Apr 11, 2024

tiancaiamao commented Apr 12, 2024

View reviewed changes

time-and-fate approved these changes Apr 12, 2024

View reviewed changes

ti-chi-bot bot added the approved label Apr 12, 2024

ti-chi-bot bot merged commit 5954be7 into pingcap:master Apr 12, 2024
25 checks passed

tiancaiamao deleted the v2-ci branch April 12, 2024 10:07

3AceShowHand pushed a commit to 3AceShowHand/tidb that referenced this pull request Apr 16, 2024

*: let our unit test cover the infoschema v2 code (pingcap#52156)

117e1a6

ref pingcap#50959

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: let our unit test cover the infoschema v2 code #52156

*: let our unit test cover the infoschema v2 code #52156

tiancaiamao commented Mar 27, 2024

tiprow bot commented Mar 27, 2024

codecov bot commented Mar 27, 2024 •

edited

tiancaiamao commented Mar 27, 2024

tiancaiamao commented Mar 27, 2024

tiprow bot commented Mar 27, 2024

tiancaiamao commented Mar 27, 2024

ti-chi-bot bot commented Mar 27, 2024

tiprow bot commented Mar 27, 2024

tiancaiamao commented Mar 28, 2024

tiprow bot commented Mar 28, 2024

ti-chi-bot bot commented Apr 8, 2024

GMHDBJD left a comment

ti-chi-bot bot commented Apr 11, 2024

tiancaiamao Apr 12, 2024

easonn7 commented Apr 12, 2024

ti-chi-bot bot commented Apr 12, 2024

tiancaiamao commented Apr 12, 2024

tiprow bot commented Apr 12, 2024

*: let our unit test cover the infoschema v2 code #52156

*: let our unit test cover the infoschema v2 code #52156

Conversation

tiancaiamao commented Mar 27, 2024

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Mar 27, 2024

codecov bot commented Mar 27, 2024 • edited

Codecov Report

tiancaiamao commented Mar 27, 2024

tiancaiamao commented Mar 27, 2024

tiprow bot commented Mar 27, 2024

tiancaiamao commented Mar 27, 2024

ti-chi-bot bot commented Mar 27, 2024

tiprow bot commented Mar 27, 2024

tiancaiamao commented Mar 28, 2024

tiprow bot commented Mar 28, 2024

ti-chi-bot bot commented Apr 8, 2024

GMHDBJD left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Apr 11, 2024

[LGTM Timeline notifier]

tiancaiamao Apr 12, 2024

Choose a reason for hiding this comment

easonn7 commented Apr 12, 2024

ti-chi-bot bot commented Apr 12, 2024

tiancaiamao commented Apr 12, 2024

tiprow bot commented Apr 12, 2024

codecov bot commented Mar 27, 2024 •

edited