New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: add lock time in total time of insert execution info #52211
Conversation
Signed-off-by: Jack Yu <jackysp@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52211 +/- ##
================================================
+ Coverage 70.6776% 72.7059% +2.0282%
================================================
Files 1489 1495 +6
Lines 440013 444577 +4564
================================================
+ Hits 310991 323234 +12243
+ Misses 109483 101016 -8467
- Partials 19539 20327 +788
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: you06, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
What problem does this PR solve?
Issue Number: close #52174
Problem Summary:
For no delayed DML execution (insert/update/delete), the query locks keys after execution, which make the lock duration be excluded in the total execution time. But for select for update statement, it is included.
What changed and how does it work?
Add the lock duration to execution info for pessimistic DMLs.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.