Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/ranger: Handle boundary value correctly in ranger to avoid incorrect tableDual plan #52225

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

onlyacat
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #50051

Problem Summary:

The function excludeToIncludeForIntPoint should deal with the boundary value correctly.

What changed and how does it work?

I guess it is not a bad idea to change the type of the point in this case.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Mar 29, 2024
Copy link

ti-chi-bot bot commented Mar 29, 2024

Hi @onlyacat. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Mar 29, 2024

Hi @onlyacat. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@onlyacat onlyacat changed the title Handle boundary value correctly in ranger to avoid incorrect tableDual plan util/ranger: Handle boundary value correctly in ranger to avoid incorrect tableDual plan Mar 29, 2024
@onlyacat
Copy link
Contributor Author

onlyacat commented Apr 3, 2024

PTAL @wjhuang2016 @fixdb

@wjhuang2016
Copy link
Member

/ok-to-test

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Merging #52225 (5aa4aee) into master (cfbabfa) will decrease coverage by 17.2296%.
Report is 23 commits behind head on master.
The diff coverage is 66.6666%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52225         +/-   ##
=================================================
- Coverage   72.3769%   55.1474%   -17.2296%     
=================================================
  Files          1474       1674        +200     
  Lines        427589     644891     +217302     
=================================================
+ Hits         309476     355641      +46165     
- Misses        98890     266011     +167121     
- Partials      19223      23239       +4016     
Flag Coverage Δ
integration 37.7420% <16.6666%> (?)
unit 71.9535% <66.6666%> (+0.6935%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 28.5296% <ø> (-12.6797%) ⬇️

Copy link

ti-chi-bot bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: winoros, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [winoros,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-10 06:59:12.571209658 +0000 UTC m=+1032014.098750201: ☑️ agreed by wjhuang2016.
  • 2024-04-24 17:56:44.690494923 +0000 UTC m=+196561.430397835: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit 3292909 into pingcap:master Apr 24, 2024
23 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 25, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #52875.

@hawkingrei
Copy link
Member

/cherrypick release-8.1

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #53295.

In response to this:

/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member

/cherrypick release-7.1
/cherrypick release-6.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-6.5: #53319.

In response to this:

/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.1: #53320.

In response to this:

/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor

qw4990 commented May 20, 2024

/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-8.1 from head ti-chi-bot:cherry-pick-52225-to-release-8.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-8.1 and ti-chi-bot:cherry-pick-52225-to-release-8.1"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

@ti-chi-bot
Copy link
Member

@qw4990: new pull request could not be created: failed to create pull request against pingcap/tidb#release-8.1 from head ti-chi-bot:cherry-pick-52225-to-release-8.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-8.1 and ti-chi-bot:cherry-pick-52225-to-release-8.1"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request May 28, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jun 5, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jun 28, 2024
@winoros
Copy link
Member

winoros commented Jul 31, 2024

/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

@winoros: new pull request could not be created: failed to create pull request against pingcap/tidb#release-8.1 from head ti-chi-bot:cherry-pick-52225-to-release-8.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-8.1 and ti-chi-bot:cherry-pick-52225-to-release-8.1"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect tableDual plan which would cause no result
6 participants