New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix distorted join probe time #52227
executor: fix distorted join probe time #52227
Conversation
Hi @windtalker. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
61c1ac4
to
bd126f6
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52227 +/- ##
================================================
+ Coverage 74.1468% 74.3235% +0.1767%
================================================
Files 1467 1467
Lines 354142 426737 +72595
================================================
+ Hits 262585 317166 +54581
- Misses 72388 89733 +17345
- Partials 19169 19838 +669
Flags with carried forward coverage won't be shown. Click here to find out more.
|
8caf208
to
f876b82
Compare
@@ -985,12 +994,14 @@ func (w *probeWorker) getNewJoinResult() (bool, *hashjoinWorkerResult) { | |||
} | |||
|
|||
func (w *probeWorker) join2Chunk(probeSideChk *chunk.Chunk, hCtx *hashContext, joinResult *hashjoinWorkerResult, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment for waitTime
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
f876b82
to
8c5939f
Compare
@@ -1633,7 +1661,7 @@ func (e *hashJoinRuntimeStats) String() string { | |||
buf.WriteString(execdetails.FormatDuration(time.Duration(atomic.LoadInt64(&e.maxFetchAndProbe)))) | |||
buf.WriteString(", probe:") | |||
buf.WriteString(execdetails.FormatDuration(time.Duration(e.probe))) | |||
buf.WriteString(", fetch:") | |||
buf.WriteString(", fetch and wait:") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment for what does fetch and wait
mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
8c5939f
to
bfd2beb
Compare
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufei@pingcap.com>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
bfd2beb
to
977ee2c
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wshwsh12, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #52222
Problem Summary:
What changed and how does it work?
Check List
Tests
run TPCH query 10 base on TPCH-50 dataset
Before this pr
The displayed probe time 27.9s for
HashJoin_88
is 27.9s and 32.2s forHashJoin_99
After this pr
The displayed probe time is 3.16s for
HashJoin_88
and 7.72s forHashJoin_99
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.