test: fix TestGetMergeRegionSizeAndCount test #52241
Conversation
ti-chi-bot
bot
added
release-note-none
do-not-merge/needs-triage-completed
size/XS
|
Hi @3pointer. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
br/pkg/conn/conn_test.go
Outdated
| @@ -406,6 +406,8 @@ func TestGetMergeRegionSizeAndCount(t *testing.T) { | |||
| } | |||
|
|
|||
| ctx := context.Background() | |||
| failpoint.Enable("github.com/pingcap/tidb/br/pkg/conn/stop-retry-on-get-config-from-tikv", "return(true)") | |||
There was a problem hiding this comment.
It should check whether to return the no error. it will return an error if failpoint is deleted.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52241 +/- ##
================================================
- Coverage 72.4066% 71.3435% -1.0632%
================================================
Files 1490 1540 +50
Lines 366244 460545 +94301
================================================
+ Hits 265185 328569 +63384
- Misses 81476 111572 +30096
- Partials 19583 20404 +821
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/ok-to-test |
|
/retest |
|
/check-issue-triage-complete |
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
ti-chi-bot
bot
added
size/S
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
|
/test pull-br-integration-test |
|
@Leavrth: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
ti-chi-bot
bot
added
size/M
|
/test pull-br-integration-test |
|
@Leavrth: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #52095 #52094
Problem Summary:
the backoff case will cost too mush time.
What changed and how does it work?
use failpoint and return parse error immediately.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.