Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placement: fix alter placement policy cannot update the relative ranges policy #52254

Merged
merged 6 commits into from
May 7, 2024

Conversation

jiyfhust
Copy link
Contributor

@jiyfhust jiyfhust commented Mar 30, 2024

What problem does this PR solve?

Issue Number: close #51712 close #52257

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 30, 2024
Copy link

tiprow bot commented Mar 30, 2024

Hi @jiyfhust. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 63.75000% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 73.9705%. Comparing base (555ce02) to head (378227d).
Report is 194 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52254        +/-   ##
================================================
+ Coverage   70.1622%   73.9705%   +3.8082%     
================================================
  Files          1485       1511        +26     
  Lines        419217     467558     +48341     
================================================
+ Hits         294132     345855     +51723     
+ Misses       105672     101191      -4481     
- Partials      19413      20512      +1099     
Flag Coverage Δ
integration 48.3273% <40.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.8802% <ø> (-2.4170%) ⬇️
parser ∅ <ø> (∅)
br 43.5831% <ø> (+1.3351%) ⬆️

@jiyfhust
Copy link
Contributor Author

/ok-to-test

@jiyfhust
Copy link
Contributor Author

/test tidb_parser_test

Copy link

ti-chi-bot bot commented Mar 31, 2024

@jiyfhust: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pull-br-integration-test
  • /test pull-integration-ddl-test
  • /test pull-lightning-integration-test
  • /test pull-mysql-client-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test canary-notify-when-compatibility-sections-changed
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-common-test
  • /test pull-e2e-test
  • /test pull-integration-common-test
  • /test pull-integration-copr-test
  • /test pull-integration-jdbc-test
  • /test pull-integration-mysql-test
  • /test pull-integration-nodejs-test
  • /test pull-sqllogic-test
  • /test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test
  • pingcap/tidb/pull_integration_ddl_test
  • pingcap/tidb/pull_mysql_client_test

In response to this:

/test tidb_parser_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

@jiyfhust Please sync with master.

@jiyfhust
Copy link
Contributor Author

jiyfhust commented Apr 1, 2024

/cc @nolouch

@ti-chi-bot ti-chi-bot bot requested a review from nolouch April 1, 2024 01:04
@jiyfhust
Copy link
Contributor Author

jiyfhust commented Apr 1, 2024

/retest-required

@jiyfhust
Copy link
Contributor Author

jiyfhust commented Apr 1, 2024

/cc @zimulala

@ti-chi-bot ti-chi-bot bot requested a review from zimulala April 1, 2024 04:56
@nolouch nolouch requested a review from lcwangchao April 8, 2024 09:32
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@jiyfhust
Copy link
Contributor Author

/cc @xhebox

@ti-chi-bot ti-chi-bot bot requested a review from xhebox April 12, 2024 01:21
Copy link

ti-chi-bot bot commented Apr 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-08 09:55:19.399449279 +0000 UTC m=+869780.926989825: ☑️ agreed by nolouch.
  • 2024-04-12 03:07:34.411193589 +0000 UTC m=+1190915.938734137: ☑️ agreed by xhebox.

@jiyfhust
Copy link
Contributor Author

please assign benjamin2037 for approval.

PTAL @zimulala @Benjamin2037

@jiyfhust
Copy link
Contributor Author

/cc @Benjamin2037

@ti-chi-bot ti-chi-bot bot requested a review from Benjamin2037 April 12, 2024 05:47
@nolouch
Copy link
Member

nolouch commented May 7, 2024

/test

Copy link

ti-chi-bot bot commented May 7, 2024

@nolouch: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pull-br-integration-test
  • /test pull-integration-ddl-test
  • /test pull-lightning-integration-test
  • /test pull-mysql-client-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test canary-notify-when-compatibility-sections-changed
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-common-test
  • /test pull-e2e-test
  • /test pull-integration-common-test
  • /test pull-integration-copr-test
  • /test pull-integration-jdbc-test
  • /test pull-integration-mysql-test
  • /test pull-integration-nodejs-test
  • /test pull-sqllogic-test
  • /test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test
  • pingcap/tidb/pull_integration_ddl_test
  • pingcap/tidb/pull_mysql_client_test

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nolouch
Copy link
Member

nolouch commented May 7, 2024

/retest-required

Copy link

ti-chi-bot bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, xhebox, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit 65817ac into pingcap:master May 7, 2024
21 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 7, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #53077.

@jiyfhust jiyfhust deleted the fix_placement_range branch May 7, 2024 09:36
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
ti-chi-bot bot pushed a commit that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 ok-to-test release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
6 participants