Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br, lightning: move *batch* split region logic into common package #52300

Merged
merged 8 commits into from Apr 7, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Apr 2, 2024

What problem does this PR solve?

Issue Number: ref #51533

Problem Summary:

What changed and how does it work?

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2024
Copy link

tiprow bot commented Apr 2, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-tests-checked labels Apr 2, 2024
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test label Apr 2, 2024
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Merging #52300 (dcd7f5d) into master (d971a6d) will increase coverage by 1.1671%.
Report is 21 commits behind head on master.
The diff coverage is 76.7441%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52300        +/-   ##
================================================
+ Coverage   72.1348%   73.3019%   +1.1671%     
================================================
  Files          1467       1468         +1     
  Lines        426605     432871      +6266     
================================================
+ Hits         307731     317303      +9572     
+ Misses        99686      95730      -3956     
- Partials      19188      19838       +650     
Flag Coverage Δ
integration 48.6924% <44.1860%> (?)
unit 70.9801% <70.9302%> (-0.0324%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 41.5768% <72.7272%> (+0.9756%) ⬆️

@lance6716
Copy link
Contributor Author

/test pull-lightning-integration-test

@lance6716
Copy link
Contributor Author

/test pull-br-integration-test

@lance6716 lance6716 changed the title [WIP]lightning: move the batch split region logic into common package lightning: move the batch split region logic into common package Apr 2, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2024
Copy link

tiprow bot commented Apr 2, 2024

@lance6716: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Apr 2, 2024

@lance6716: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
Copy link
Contributor Author

/test pull-lightning-integration-test

Copy link

tiprow bot commented Apr 2, 2024

@lance6716: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8/11

Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title lightning: move the batch split region logic into common package br, lightning: move the batch split region logic into common package Apr 2, 2024
@lance6716 lance6716 changed the title br, lightning: move the batch split region logic into common package br, lightning: move the *batch* split region logic into common package Apr 2, 2024
@lance6716 lance6716 changed the title br, lightning: move the *batch* split region logic into common package br, lightning: move *batch* split region logic into common package Apr 2, 2024
Comment on lines +180 to +181
// TODO(lance6716): now the retryKeys can not be shrank to the middle of the keys
// and it will retry all keys of the region. Will fix it in future PR.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to pick to 8.1 if the pr is not merged before 4.9

Copy link
Contributor

@Leavrth Leavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

br/pkg/restore/split/client.go Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Apr 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-03 02:30:00.82864814 +0000 UTC m=+411062.356188682: ☑️ agreed by D3Hunter.
  • 2024-04-07 02:22:52.155427355 +0000 UTC m=+756233.682967901: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot bot merged commit bdffd30 into pingcap:master Apr 7, 2024
31 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants