New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br, lightning: move *batch* split region logic into common package #52300
Conversation
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52300 +/- ##
================================================
+ Coverage 72.1348% 73.3019% +1.1671%
================================================
Files 1467 1468 +1
Lines 426605 432871 +6266
================================================
+ Hits 307731 317303 +9572
+ Misses 99686 95730 -3956
- Partials 19188 19838 +650
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test pull-lightning-integration-test |
/test pull-br-integration-test |
@lance6716: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lance6716: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-lightning-integration-test |
@lance6716: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8/11
Signed-off-by: lance6716 <lance6716@gmail.com>
// TODO(lance6716): now the retryKeys can not be shrank to the middle of the keys | ||
// and it will retry all keys of the region. Will fix it in future PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need to pick to 8.1 if the pr is not merged before 4.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #51533
Problem Summary:
What changed and how does it work?
Check List
Tests
BR https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fpull_br_integration_test/detail/pull_br_integration_test/99/pipeline
lightning https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fpull_lightning_integration_test/detail/pull_lightning_integration_test/152/pipeline
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.