New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: separate BuildContext
and EvalContext
#52311
Conversation
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2bdaf6f
to
c8e25dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, tangenta, XuHuaiyu, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #52310
Problem Summary:
It's better to separate
EvalContext
andBuildContext
in expression because they all have their respective method in semantics.For example, if we add a new method
EvalContext.Clone
in the future to "clone" anEvalContext
,BuildContext
will also have this method in the current implementation becauseBuildContext
extendsEvalContext
. It is strange thatBuildContext.Clone
can be called and anEvalContext
returns, so it's better to separate these two methods.What changed and how does it work?
BuildContext
does not extendEvalContext
anymore in this PR.BuildContext
gives a new methodGetEvalContext
to return the context for evaluation.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.