Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: fix TIDB_ROW_ID_SHARDING_INFO for composite primary key #52331

Merged
merged 3 commits into from Apr 15, 2024

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Apr 3, 2024

What problem does this PR solve?

Issue Number: close #52330

Problem Summary: See #52330

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2024
Copy link

tiprow bot commented Apr 3, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Merging #52331 (8607ff4) into master (9ad0862) will increase coverage by 0.2867%.
Report is 74 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52331        +/-   ##
================================================
+ Coverage   74.1468%   74.4335%   +0.2867%     
================================================
  Files          1467       1471         +4     
  Lines        354142     441591     +87449     
================================================
+ Hits         262585     328692     +66107     
- Misses        72388      92669     +20281     
- Partials      19169      20230      +1061     
Flag Coverage Δ
integration 48.9527% <100.0000%> (?)
unit 71.1657% <100.0000%> (-1.7389%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 47.7219% <ø> (+5.5708%) ⬆️

@tangenta
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Apr 12, 2024

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-12 07:03:28.086773845 +0000 UTC m=+1205069.614314386: ☑️ agreed by Defined2014.
  • 2024-04-12 07:06:23.344088214 +0000 UTC m=+1205244.871628761: ☑️ agreed by zimulala.

Copy link

ti-chi-bot bot commented Apr 12, 2024

@tangenta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test 0ee12a8 link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit eff809f into pingcap:master Apr 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TIDB_ROW_ID_SHARDING_INFO is wrong for composite primary key
3 participants