New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor, planner: add a smaller context for ToPB
method
#52369
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52369 +/- ##
================================================
+ Coverage 72.2371% 74.3480% +2.1109%
================================================
Files 1467 1467
Lines 426991 427079 +88
================================================
+ Hits 308446 317525 +9079
+ Misses 99430 89714 -9716
- Partials 19115 19840 +725
Flags with carried forward coverage won't be shown. Click here to find out more.
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@YangKeao: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #52368
Problem Summary:
The
PlanCtx
is too big to callToPB
method. We can use a much smaller context forToPB
method.What changed and how does it work?
Use a smaller struct to represent all information needed by the
ToPB
method call.Check List
Tests
Side effects
Documentation
Release note