Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, planner: add a smaller context for ToPB method #52369

Merged
merged 2 commits into from Apr 10, 2024

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Apr 7, 2024

What problem does this PR solve?

Issue Number: close #52368

Problem Summary:

The PlanCtx is too big to call ToPB method. We can use a much smaller context for ToPB method.

What changed and how does it work?

Use a smaller struct to represent all information needed by the ToPB method call.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

    Should be covered by existing tests.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2024
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Merging #52369 (bd3814d) into master (312b69f) will increase coverage by 2.1109%.
Report is 1 commits behind head on master.
The diff coverage is 86.3157%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52369        +/-   ##
================================================
+ Coverage   72.2371%   74.3480%   +2.1109%     
================================================
  Files          1467       1467                
  Lines        426991     427079        +88     
================================================
+ Hits         308446     317525      +9079     
+ Misses        99430      89714      -9716     
- Partials      19115      19840       +725     
Flag Coverage Δ
integration 48.7510% <56.8421%> (?)
unit 71.0016% <86.3157%> (-0.1267%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.7599% <ø> (+8.6346%) ⬆️

@ti-chi-bot ti-chi-bot bot added sig/planner SIG: Planner needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 9, 2024
Copy link

ti-chi-bot bot commented Apr 9, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Apr 9, 2024

@YangKeao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test 8cb5a20 link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Copy link

ti-chi-bot bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-09 03:36:04.629897351 +0000 UTC m=+933426.157437892: ☑️ agreed by hawkingrei.
  • 2024-04-10 04:03:00.804189412 +0000 UTC m=+1021442.331729954: ☑️ agreed by lcwangchao.

@YangKeao YangKeao removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2024
@ti-chi-bot ti-chi-bot bot merged commit 6cca89c into pingcap:master Apr 10, 2024
23 checks passed
3AceShowHand pushed a commit to 3AceShowHand/tidb that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimize the context used in ToPB
3 participants