Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: set session id of committer once txn is activated #52388

Merged
merged 4 commits into from Apr 8, 2024

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Apr 7, 2024

What problem does this PR solve?

Issue Number: ref #50215

Problem Summary:

What changed and how does it work?

Pass the session id to the transaction committer once the transaction is activated.
Depends on tikv/client-go#1270

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

The logs will be like

[2024/04/07 20:38:38.635 +08:00] [INFO] [pipelined_flush.go:302] ["[pipelined dml] start to commit transaction"] [keys=1] [size=29B] [startTS=448919900943810561] [session=996147206]
[2024/04/07 20:38:38.636 +08:00] [INFO] [pipelined_flush.go:331] ["[pipelined dml] transaction is committed"] [startTS=448919900943810561] [commitTS=448919900943810564] [session=996147206]

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 7, 2024
Copy link

tiprow bot commented Apr 7, 2024

Hi @ekexium. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ekexium ekexium requested review from cfzjywxk and you06 April 7, 2024 12:42
Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Merging #52388 (d9dc938) into master (c39d79f) will increase coverage by 0.2093%.
Report is 2 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52388        +/-   ##
================================================
+ Coverage   74.1210%   74.3304%   +0.2093%     
================================================
  Files          1467       1467                
  Lines        354273     426906     +72633     
================================================
+ Hits         262591     317321     +54730     
- Misses        72444      89745     +17301     
- Partials      19238      19840       +602     
Flag Coverage Δ
integration 48.7696% <100.0000%> (?)
unit 70.9951% <100.0000%> (-1.8840%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 49.5815% <ø> (+7.1436%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2024
Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2024
@ekexium ekexium requested a review from crazycs520 April 8, 2024 10:02
Copy link

ti-chi-bot bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, crazycs520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cfzjywxk,crazycs520]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-08 11:30:43.090545032 +0000 UTC m=+875504.618085577: ☑️ agreed by cfzjywxk.
  • 2024-04-08 11:35:32.225829592 +0000 UTC m=+875793.753370137: ☑️ agreed by crazycs520.

@ti-chi-bot ti-chi-bot bot merged commit 0ce42ed into pingcap:master Apr 8, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants