disttask: enable on default #52401
disttask: enable on default #52401
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
size/M
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52401 +/- ##
================================================
+ Coverage 74.1411% 76.3249% +2.1837%
================================================
Files 1467 1493 +26
Lines 354227 448518 +94291
================================================
+ Hits 262628 342331 +79703
- Misses 72389 85437 +13048
- Partials 19210 20750 +1540
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
size/L
| PRIMARY KEY (`id`) /*T![clustered_index] CLUSTERED */, | ||
| KEY `idx_task_key` (`task_key`), | ||
| KEY `idx_state_update_time` (`state_update_time`) | ||
| ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin |
There was a problem hiding this comment.
after enable disttask on default, this will return AUTO_INCREMENT=xxx
ti-chi-bot
bot
added
the
do-not-merge/work-in-progress
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
| if ver > version195 { | ||
| // since version195 we enable dist task by default, no need to check | ||
| return | ||
| } |
There was a problem hiding this comment.
@zimulala @wjhuang2016 ptal
[LGTM Timeline notifier]Timeline:
|
|
/approve |
1 similar comment
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, easonn7, wjhuang2016, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #52441
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.