Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statstics: forcely use index to order when to init stats #52462

Merged
merged 3 commits into from Apr 11, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Apr 9, 2024

What problem does this PR solve?

Issue Number: close #52466

Problem Summary:

What changed and how does it work?

forcely use index to order when to init stats

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

before:

image

img_v3_029p_ac3d7ef4-53d6-48f6-b8b1-bc79c92ba99g

You will see that sort will be executed in the tidb.

after:

image
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 9, 2024
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Merging #52462 (40aff17) into master (312b69f) will increase coverage by 0.7093%.
The diff coverage is 33.3333%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52462        +/-   ##
================================================
+ Coverage   72.1347%   72.8441%   +0.7093%     
================================================
  Files          1467       1467                
  Lines        426991     426991                
================================================
+ Hits         308009     311038      +3029     
+ Misses        99736      96578      -3158     
- Partials      19246      19375       +129     
Flag Coverage Δ
integration 24.1483% <33.3333%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 41.4409% <ø> (+0.3457%) ⬆️

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link

ti-chi-bot bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-10 11:16:41.961696446 +0000 UTC m=+1047463.489236995: ☑️ agreed by winoros.
  • 2024-04-11 06:17:00.206153059 +0000 UTC m=+1115881.733693639: ☑️ agreed by hi-rustin.

@ti-chi-bot ti-chi-bot bot merged commit 87b8d01 into pingcap:master Apr 11, 2024
21 of 24 checks passed
@hawkingrei
Copy link
Member Author

/cherrypick release-7.5
/cherrypick release-8.1

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #52507.

In response to this:

/cherrypick release-7.5
/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 11, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #52508.

In response to this:

/cherrypick release-7.5
/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

orderby doesn't use the index when to init stats
4 participants