expression: create a new context in ColumnInfos2ColumnsAndNames to ignore truncate error
#52468
Conversation
ti-chi-bot
bot
added
release-note-none
size/M
|
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
lcwangchao
force-pushed
the
ignore_truncate_ctx
branch
from
0e270e2
to
cc7225e
Compare
ti-chi-bot
bot
added
size/L
…ignore truncate error
lcwangchao
force-pushed
the
ignore_truncate_ctx
branch
from
cc7225e
to
38029e6
Compare
| // See the comment of `ColumnInfos2ColumnsAndNames`. It's fixing #42341 | ||
| originalTypeFlags := e.Ctx().GetSessionVars().StmtCtx.TypeFlags() | ||
| defer func() { | ||
| e.Ctx().GetSessionVars().StmtCtx.SetTypeFlags(originalTypeFlags) | ||
| }() | ||
| e.Ctx().GetSessionVars().StmtCtx.SetTypeFlags(originalTypeFlags.WithIgnoreTruncateErr(true)) | ||
|
|
There was a problem hiding this comment.
It is not needed anymore because ColumnInfos2ColumnsAndNames is thread-safe
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52468 +/- ##
================================================
+ Coverage 72.2371% 73.3372% +1.1001%
================================================
Files 1467 1467
Lines 426991 427976 +985
================================================
+ Hits 308446 313866 +5420
+ Misses 99430 94604 -4826
- Partials 19115 19506 +391
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XuHuaiyu, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52468 +/- ##
================================================
+ Coverage 72.2371% 73.5270% +1.2898%
================================================
Files 1467 1489 +22
Lines 426991 436120 +9129
================================================
+ Hits 308446 320666 +12220
+ Misses 99430 95333 -4097
- Partials 19115 20121 +1006
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ignore truncate error (pingcap#52468) close pingcap#52366
What problem does this PR solve?
Issue Number: close #52366
Problem Summary:
Before this PR,
ColumnInfos2ColumnsAndNamesis not thread-safe because it will modify the inner state of context to force ignore truncate error. It's better to make it thread-safe and remove calls ofGetSessionVarsin it.What changed and how does it work?
Add
ignoreTruncateExprCtxto ignore the truncate error and makeColumnInfos2ColumnsAndNamesthread safeCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.