New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: fix large float64 to bigint #5247
Conversation
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
oh, gofmt check failed. I will fix it. |
I was curious how you could push your code through the yellow cloud. Now I get the answer. |
@XuHuaiyu PTAL |
/ok-to-test |
/run-all-tests |
LGTM |
@jackysp PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix #4287.
Direct conversion has a bit diff. eg.
Here is the code from mysql.
https://github.com/mysql/mysql-server/blob/0138556a55168da12eaf0bc3038947148d6b0863/sql/field.cc#L4335