distsql, executor: remove pctx from trectx #52496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
ti-chi-bot
bot
added
release-note-none
size/M
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
YangKeao
force-pushed
the
remove-pctx-from-trectx
branch
from
add006b
to
b330291
Compare
lcwangchao
approved these changes
Apr 11, 2024
XuHuaiyu
approved these changes
Apr 15, 2024
[LGTM Timeline notifier]Timeline:
|
zimulala
approved these changes
Apr 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, XuHuaiyu, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52496 +/- ##
================================================
+ Coverage 72.2344% 75.1523% +2.9179%
================================================
Files 1469 1470 +1
Lines 427098 434565 +7467
================================================
+ Hits 308512 326586 +18074
+ Misses 99447 88266 -11181
- Partials 19139 19713 +574
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3AceShowHand
pushed a commit
to 3AceShowHand/tidb
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #52495
Problem Summary:
We have splited
PlanContextinto some tiny contexts (BuildPBContextandRangerContext). Now it's time to remove thepctxfromtableReaderExecutorContext.What changed and how does it work?
pctxfromtableReaderExecutorContext.anyindistsqlintoMetaOnlyInfoSchema(I don't know why it's originallyany. Maybe it's used to avoid cyclic dependency?)Check List
Tests
Side effects
Documentation
Release note