New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor,planner: Relax projection column expression push down check conditions #52502
executor,planner: Relax projection column expression push down check conditions #52502
Conversation
Signed-off-by: yibin <huyibin@pingcap.com>
Hi @yibin87. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @windtalker @SeaRise |
Signed-off-by: yibin <huyibin@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52502 +/- ##
================================================
+ Coverage 70.7712% 73.4549% +2.6837%
================================================
Files 1470 1470
Lines 408762 433648 +24886
================================================
+ Hits 289286 318536 +29250
+ Misses 100177 95498 -4679
- Partials 19299 19614 +315
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: yibin <huyibin@pingcap.com>
Signed-off-by: yibin <huyibin@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And add some tests?
// some cases from update optimize will require avoiding projection elimination. | ||
// see comments ahead of call of DoOptimize in function of buildUpdate(). | ||
err := prunePhysicalColumns(sctx, plan) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is removed because afte #52143, it is useless?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
Will add it |
Signed-off-by: yibin <huyibin@pingcap.com>
Done |
/cc @winoros |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[LGTM Timeline notifier]Timeline:
|
/hold |
comment |
Co-authored-by: SeaRise <hhssearise@foxmail.com>
/unhold |
Signed-off-by: yibin <huyibin@pingcap.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SeaRise, windtalker, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: yibin <huyibin@pingcap.com>
Signed-off-by: yibin <huyibin@pingcap.com>
What problem does this PR solve?
Issue Number: close #52501
Problem Summary:
In #52143 , new projections might be added above join/selection operators, the output schema of projections may contain limit-supported data types. These data types are allowed for just reading without any calculations. For projection operators, column expression satisfy the rule, so relax it.
Besides, eliminate the MPP specific prunePhysicalColumns logic, since these cases are completely handled by #52143 already.
What changed and how does it work?
Check List
Tests
TiFlash ci tests contain integration tests that covers the changes.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.