Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: remove useless GetFullTableName #52552

Merged

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Apr 12, 2024

What problem does this PR solve?

Issue Number: close #52553

Problem Summary:

What changed and how does it work?

GetFullTableName only is used in the write, but nothing will read it. so we can remove this useless function.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei changed the title statistics: reduce cost on the GetFullTableName statistics: remove useless GetFullTableName Apr 12, 2024
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei requested review from winoros, qw4990 and hi-rustin and removed request for winoros and qw4990 April 12, 2024 08:45
Copy link

ti-chi-bot bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-12 08:49:00.524811219 +0000 UTC m=+1211402.052351762: ☑️ agreed by hi-rustin.
  • 2024-04-12 08:54:22.011055203 +0000 UTC m=+1211723.538595749: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit 69d7770 into pingcap:master Apr 12, 2024
23 checks passed
@hawkingrei
Copy link
Member Author

/cherrypick release-7.5
/cherrypick release-8.1

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #52587.

In response to this:

/cherrypick release-7.5
/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #52588.

In response to this:

/cherrypick release-7.5
/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 12, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Apr 12, 2024
3AceShowHand pushed a commit to 3AceShowHand/tidb that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poor performance on the GetFullTableName when to init stats
4 participants