Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix RU missing for DML stmtatement in explain analyze #52576

Merged
merged 3 commits into from Apr 15, 2024

Conversation

guo-shaoge
Copy link
Collaborator

@guo-shaoge guo-shaoge commented Apr 12, 2024

What problem does this PR solve?

Issue Number: close #52575

Problem Summary:

What changed and how does it work?

revert https://github.com/pingcap/tidb/pull/50406/files#diff-b547451eec63d4e7c0f11051814ff0d74aa0c742d6b45c82e0c92012b2f3960c

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

71cd942f-731c-4980-a977-08fe0b479245

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

executor: fix RU missing for DML stmtatement in explain analyze

Signed-off-by: guo-shaoge <shaoge1994@163.com>
Copy link

tiprow bot commented Apr 12, 2024

Hi @guo-shaoge. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guo-shaoge guo-shaoge changed the title executor: fix RU missing in insert stmt executor: fix RU missing in DML stmtatement Apr 12, 2024
@guo-shaoge guo-shaoge changed the title executor: fix RU missing in DML stmtatement executor: fix RU missing for DML stmtatement in explain analyze Apr 12, 2024
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Merging #52576 (658a94e) into master (c39d79f) will increase coverage by 0.0802%.
Report is 53 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52576        +/-   ##
================================================
+ Coverage   74.1210%   74.2013%   +0.0802%     
================================================
  Files          1467       1471         +4     
  Lines        354273     439635     +85362     
================================================
+ Hits         262591     326215     +63624     
- Misses        72444      93279     +20835     
- Partials      19238      20141       +903     
Flag Coverage Δ
integration 48.3476% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 47.8908% <ø> (+5.4530%) ⬆️

Signed-off-by: guo-shaoge <shaoge1994@163.com>
Copy link

ti-chi-bot bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wshwsh12, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-15 08:53:34.59831875 +0000 UTC m=+241833.709365199: ☑️ agreed by XuHuaiyu.
  • 2024-04-15 08:54:53.747920321 +0000 UTC m=+241912.858966766: ☑️ agreed by wshwsh12.

@guo-shaoge
Copy link
Collaborator Author

/retest

Copy link

tiprow bot commented Apr 15, 2024

@guo-shaoge: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit f2fb909 into pingcap:master Apr 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RU info is missing in explain analyze for DML statements
3 participants