Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroup: remove redundant log #52611

Merged
merged 1 commit into from Apr 15, 2024
Merged

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Apr 15, 2024

What problem does this PR solve?

Issue Number: close #52612

Problem Summary: The CDC cli will print a redundant log and we could remove it.
img_v3_029v_4bc7d062-584b-4da9-b393-f29aa1d9c4cg

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2024
@Defined2014 Defined2014 added skip-issue-check and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2024
Copy link

tiprow bot commented Apr 15, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2024
@Defined2014
Copy link
Contributor Author

/check-issue-triage-complete

Copy link

ti-chi-bot bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-15 11:28:54.130199084 +0000 UTC m=+251153.241245530: ☑️ agreed by hawkingrei.
  • 2024-04-15 14:01:14.008159576 +0000 UTC m=+260293.119206014: ☑️ agreed by lance6716.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Merging #52611 (10cd497) into master (5aa48d8) will increase coverage by 2.0421%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52611        +/-   ##
================================================
+ Coverage   72.3481%   74.3903%   +2.0421%     
================================================
  Files          1470       1470                
  Lines        427158     427717       +559     
================================================
+ Hits         309041     318180      +9139     
+ Misses        98845      89708      -9137     
- Partials      19272      19829       +557     
Flag Coverage Δ
integration 48.9631% <ø> (?)
unit 71.1834% <ø> (-0.0570%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.7359% <ø> (+8.6358%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit cd9c676 into pingcap:master Apr 15, 2024
23 checks passed
3AceShowHand pushed a commit to 3AceShowHand/tidb that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unnecessary cgroup logs printed when running cdc cli in container env
3 participants