Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix the missing type of query total counter for resource groups above 2 (#52606) #52637

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52606

What problem does this PR solve?

Issue Number: close #52605

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch requested a review from glorv April 19, 2024 09:04
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@6f93a7c). Click here to learn what that means.
The diff coverage is 23.3333%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #52637   +/-   ##
================================================
  Coverage               ?   71.9903%           
================================================
  Files                  ?       1410           
  Lines                  ?     409470           
  Branches               ?          0           
================================================
  Hits                   ?     294779           
  Misses                 ?      94861           
  Partials               ?      19830           
Flag Coverage Δ
unit 71.9903% <23.3333%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3687% <0.0000%> (?)

Signed-off-by: nolouch <nolouch@gmail.com>
Copy link

ti-chi-bot bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-19 09:06:37.536545141 +0000 UTC m=+588216.647591589: ☑️ agreed by glorv.
  • 2024-04-22 09:44:29.922631528 +0000 UTC m=+849689.033677977: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit e406d57 into pingcap:release-7.5 Apr 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants