Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: move file management into litBackendCtxMgr #52645

Merged
merged 9 commits into from Apr 22, 2024
Merged

ddl: move file management into litBackendCtxMgr #52645

merged 9 commits into from Apr 22, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Apr 16, 2024 •
edited

What problem does this PR solve?

Issue Number: close #52639

Problem Summary:

What changed and how does it work?

as title, litBackendCtxMgr should have more functionality.

This is a prepare PR to allow parallel ingest reorg in release-8.1

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716
--wip-- [skip ci]
b2134f5
@lance6716
ddl: regine cleanupSortPath
6e1b870 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title [WIP] ddl: regine cleanupSortPath [WIP] ddl: refine cleanupSortPath Apr 16, 2024
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 16, 2024
@tiprow tiprow
Copy link

tiprow bot commented Apr 16, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
fix build
a9badca 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
add IT
bea9b0d 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix bazel
47cb9f1 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title [WIP] ddl: refine cleanupSortPath ddl: refine cleanupSortPath Apr 17, 2024
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-triage-completed labels Apr 17, 2024
@lance6716 lance6716 changed the title ddl: refine cleanupSortPath ddl: move file management into litBackendCtxMgr Apr 17, 2024
@lance6716
improve robust
625f489 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix lint
94089b9 
Signed-off-by: lance6716 <lance6716@gmail.com>
D3Hunter
D3Hunter reviewed Apr 17, 2024
View reviewed changes
pkg/ddl/ingest/backend_mgr.go
@@ -106,31 +133,106 @@ func (m *litBackendCtxMgr) Register(
if !ok {
return nil, genBackendAllocMemFailedErr(ctx, m.memRoot, jobID)
}
cfg, err := genConfig(ctx, m.memRoot, jobID, unique, resourceGroupName)
cfg, err := genConfig(ctx, m.encodeJobSortPath(jobID), m.memRoot, unique, resourceGroupName)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suggest one day we remove dependency on lightning.Config, and depends on local.BackendConfig directly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

litBackendCtx still uses *lightning.Config, I'll leave it for future PR

@ywqzzy ywqzzy self-requested a review April 18, 2024 08:40
Benjamin2037
Benjamin2037 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 18, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-18 13:54:50.645185062 +0000 UTC m=+519109.756231512: ☑️ agreed by Benjamin2037.
  • 2024-04-22 03:01:54.781563204 +0000 UTC m=+825533.892609647: ☑️ agreed by tangenta.

@lance6716
Merge branch 'master' of github.com:pingcap/tidb into cleanup-by-query
d37024d 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix conflict
fac675c 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit 79c1499 into pingcap:master Apr 22, 2024
10 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #52793.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 22, 2024
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#52645
4cdb23e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 22, 2024
Closed
13 tasks
@lance6716 lance6716 mentioned this pull request Apr 25, 2024
Closed
@lance6716
Copy link
Contributor Author

/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

@lance6716: new pull request created to branch release-8.1: #52918.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 26, 2024
@lance6716 @ti-chi-bot
ddl: move file management into litBackendCtxMgr (pingcap#52645)
3219132 
close pingcap#52639
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 26, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Apr 26, 2024
@ti-chi-bot
ddl: move file management into litBackendCtxMgr (#52645) (#52918)
ac5612e 
close #52639
@lance6716 lance6716 mentioned this pull request Apr 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter left review comments

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@tangenta tangenta tangenta approved these changes

@ywqzzy ywqzzy Awaiting requested review from ywqzzy

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-8.1 release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong order of checking fast DDL available and cleanup
5 participants
@lance6716 @ti-chi-bot @D3Hunter @Benjamin2037 @tangenta