-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: reduce small obj alloc for PreCalculateScalar (#52623) #52652
statistics: reduce small obj alloc for PreCalculateScalar (#52623) #52652
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #52652 +/- ##
================================================
Coverage ? 72.2573%
================================================
Files ? 1468
Lines ? 426942
Branches ? 0
================================================
Hits ? 308497
Misses ? 99141
Partials ? 19304
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #52623
What problem does this PR solve?
Issue Number: close #52343
Problem Summary:
We don't need to re-alloc anything since we only read from the chunk, no modification after reading it.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.