planner: move debugtracer logic and handle col defition to util pkg #52681
Conversation
Signed-off-by: AilinKid <314806019@qq.com>
ti-chi-bot
bot
added
release-note-none
sig/planner
|
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52681 +/- ##
================================================
+ Coverage 72.3357% 74.3920% +2.0563%
================================================
Files 1471 1473 +2
Lines 427132 427934 +802
================================================
+ Hits 308969 318349 +9380
+ Misses 98881 89741 -9140
- Partials 19282 19844 +562
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -502,6 +503,29 @@ func GetPreparedStmt(stmt *ast.ExecuteStmt, vars *variable.SessionVars) (*PlanCa | |||
| return nil, plannererrors.ErrStmtNotFound | |||
| } | |||
|
|
|||
| func init() { | |||
| debugtrace.GetPreparedStmt = GetPreparedStmt4DebugTrace | |||
There was a problem hiding this comment.
this part is about avoiding debugTrace pkg depending on core.PlanCacheStmt. Only core pkg use debugTrace pkg is reasonable.
| */ | ||
|
|
||
| // GetStatsTblInfo is used for debug trace of getStatsTable | ||
| type GetStatsTblInfo struct { |
There was a problem hiding this comment.
move stats-related definitions to a unified place.
I saw StatsTblTraceInfo defined here, so I moved it here too. If this one is in core, any place that uses this structure will strongly depend on core too.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #51664, ref #52714
Problem Summary:
What changed and how does it work?
handlecolanddebugtraceare quite two dependent mod, we should move both parts output of core pkg.Otherwise, if we want to move physical/logical operators out of core/pkg, this
handlecolanddebugtracereference inside these operators will transitively depend on core/pkg too, leading to de-coupling work hard to process.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.