Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: fix small typo #52685

Merged
merged 1 commit into from Apr 17, 2024
Merged

statistics: fix small typo #52685

merged 1 commit into from Apr 17, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented Apr 17, 2024

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Just small typo error

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2024
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Apr 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-17 13:08:33.25634769 +0000 UTC m=+429932.367394142: ☑️ agreed by elsa0520.
  • 2024-04-17 13:11:11.959964477 +0000 UTC m=+430091.071010925: ☑️ agreed by hawkingrei.

Copy link

ti-chi-bot bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, elsa0520, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@winoros
Copy link
Member Author

winoros commented Apr 17, 2024

/retest

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Merging #52685 (d02676d) into master (5bb8ed7) will increase coverage by 1.2400%.
Report is 7 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52685        +/-   ##
================================================
+ Coverage   72.3916%   73.6317%   +1.2400%     
================================================
  Files          1471       1472         +1     
  Lines        427132     427427       +295     
================================================
+ Hits         309208     314722      +5514     
+ Misses        98724      93263      -5461     
- Partials      19200      19442       +242     
Flag Coverage Δ
integration 46.4838% <0.0000%> (?)
unit 71.1807% <100.0000%> (-0.1048%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 41.4453% <ø> (+0.3419%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 53c050b into pingcap:master Apr 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants