Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: support evict by lru cache size (#52423) #52731

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52423

What problem does this PR solve?

Issue Number: close #52237

Problem Summary:

What changed and how does it work?

Before this change, the lru cache evict is based on count.
This commit intend to support evict based on size.
Since the original sieve package does not support such operation, I modify the code base on it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Apr 30, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 78.96996% with 49 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-8.1@232c0e0). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #52731   +/-   ##
================================================
  Coverage               ?   71.1841%           
================================================
  Files                  ?       1465           
  Lines                  ?     421278           
  Branches               ?          0           
================================================
  Hits                   ?     299883           
  Misses                 ?     100945           
  Partials               ?      20450           
Flag Coverage Δ
unit 71.1841% <78.9699%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9907% <0.0000%> (?)

@wuhuizuo
Copy link
Contributor

/retest

@wuhuizuo
Copy link
Contributor

/remove-label needs-rebase

Copy link

ti-chi-bot bot commented May 11, 2024

@wuhuizuo: The label(s) needs-rebase cannot be applied. These labels are supported: fuzz/sqlancer, challenge-program, compatibility-breaker, first-time-contributor, contribution, good first issue, correctness, duplicate, proposal, security, ok-to-test, needs-ok-to-test, needs-more-info, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-cherry-pick-release-8.1, affects-5.4, affects-6.1, affects-6.5, affects-7.1, affects-7.5, affects-8.1, may-affects-5.4, may-affects-6.1, may-affects-6.5, may-affects-7.1, may-affects-7.5, may-affects-8.1.

In response to this:

/remove-label needs-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2024
Copy link

ti-chi-bot bot commented May 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-18 11:06:55.521088569 +0000 UTC m=+509034.632135019: ☑️ agreed by Benjamin2037.
  • 2024-05-11 23:31:12.309430594 +0000 UTC m=+1350426.066566168: ☑️ agreed by tiancaiamao.

@ti-chi-bot ti-chi-bot bot merged commit a1c1451 into pingcap:release-8.1 May 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants