-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema: support evict by lru cache size (#52423) #52731
infoschema: support evict by lru cache size (#52423) #52731
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #52731 +/- ##
================================================
Coverage ? 71.1841%
================================================
Files ? 1465
Lines ? 421278
Branches ? 0
================================================
Hits ? 299883
Misses ? 100945
Partials ? 20450
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
/remove-label needs-rebase |
@wuhuizuo: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #52423
What problem does this PR solve?
Issue Number: close #52237
Problem Summary:
What changed and how does it work?
Before this change, the lru cache evict is based on count.
This commit intend to support evict based on size.
Since the original sieve package does not support such operation, I modify the code base on it.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.